Skip to content

Add BooleanArray tests for null and slice behavior#9013

Merged
Jefffrey merged 3 commits intoapache:mainfrom
UtkarshSahay123:apache-first-contribution
Dec 20, 2025
Merged

Add BooleanArray tests for null and slice behavior#9013
Jefffrey merged 3 commits intoapache:mainfrom
UtkarshSahay123:apache-first-contribution

Conversation

@UtkarshSahay123
Copy link
Copy Markdown
Contributor

This PR adds unit tests for BooleanArray to improve coverage of:

  • new_null behavior
  • Slicing behavior when null values are present

There are no functional or API changes.

Tests run:

  • cargo test -p arrow-array

@github-actions github-actions bot added the arrow Changes to the arrow crate label Dec 17, 2025
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @UtkarshSahay123

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Dec 19, 2025

I took the liberty of running cargo fmt and merging up from main to get a clean CI run

@UtkarshSahay123
Copy link
Copy Markdown
Contributor Author

UtkarshSahay123 commented Dec 20, 2025 via email

Copy link
Copy Markdown
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated

@Jefffrey Jefffrey merged commit b318293 into apache:main Dec 20, 2025
28 of 30 checks passed
@Jefffrey
Copy link
Copy Markdown
Contributor

Thanks @UtkarshSahay123 & @alamb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants