minor: Add comment blocks to PR template#8994
Merged
Jefffrey merged 1 commit intoapache:mainfrom Dec 16, 2025
Merged
Conversation
alamb
approved these changes
Dec 15, 2025
| @@ -1,28 +1,38 @@ | |||
| # Which issue does this PR close? | |||
|
|
|||
| <!-- | |||
Contributor
There was a problem hiding this comment.
@kou removed these comment markers in
I actually prefer to have the comment markers as we have a bunch of commit messages now that have the template text which seems worse to me
Member
There was a problem hiding this comment.
(Sorry for your inconvenience... I hoped that contributors remove these description messages...)
Contributor
There was a problem hiding this comment.
Indeed -- I had hoped too (and that we would have the diligence to remove them) but it seems that was not the case
Contributor
|
Thank you @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So they don't show up by default on rendered view.