feat: impl BatchCoalescer::push_batch_with_indices#8991
Conversation
MVP for apache#8957 awaits for apache#8951 very first version for behaviour review, optimizations TBD Signed-off-by: 蔡略 <cailue@apache.org>
| batch: RecordBatch, | ||
| indices: &dyn Array, | ||
| ) -> Result<(), ArrowError> { | ||
| // todo: optimize this to avoid materializing (copying the results of take indices to a new batch) |
Because I dislike resolving git conflicts. :( Well you just reminded me that I have to resolve it anyway so I'll make this PR a draft and continue to optimize this PR. |
There doesn't seem to be a conflict? I think we can just merge this PR as is. |
/cc @alamb If this PR do completed all optimization, there will be possibility to conflict with the PR mentioned above. It makes sense to merge this PR first, and I'll further open up a new PR for optimization. |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think this is a good start -- let's begin with this function and optimize in subsequent PRs
|
Thank you @ClSlaid 🙏 and @Dandandan |
3 participants
MVP for #8957
awaits for #8951
very first version for reviewers to confirm behaviour, optimizations TBD