feat: implement append_array for FixedSizeBinaryBuilder#8989
Merged
alamb merged 4 commits intoapache:mainfrom Dec 17, 2025
Merged
feat: implement append_array for FixedSizeBinaryBuilder#8989alamb merged 4 commits intoapache:mainfrom
alamb merged 4 commits intoapache:mainfrom
Conversation
ClSlaid
force-pushed
the
feat/fixed-size-binary-builder/append-array
branch
from
f465a8a to
67a728d
Compare
Contributor
Author
|
/cc @lewiszlw PTAL |
mapleFU
reviewed
Dec 14, 2025
ClSlaid
force-pushed
the
feat/fixed-size-binary-builder/append-array
branch
from
67a728d to
c0b8e60
Compare
mapleFU
reviewed
Dec 14, 2025
ClSlaid
force-pushed
the
feat/fixed-size-binary-builder/append-array
branch
from
c0b8e60 to
b6d469d
Compare
mapleFU
reviewed
Dec 14, 2025
- Implemented append_array for the builder
- extends from buffers in array
- ensure value_length is compatible
- To apache#8750
Signed-off-by: 蔡略 <cailue@apache.org>
ClSlaid
force-pushed
the
feat/fixed-size-binary-builder/append-array
branch
from
b6d469d to
1e1469f
Compare
mapleFU
approved these changes
Dec 16, 2025
mapleFU
reviewed
Dec 16, 2025
Signed-off-by: 蔡略 <cailue@apache.org>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixedSizeBinaryBuildersupportsappend_array#8750Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
FixedSizeBinaryBuildersupportsappend_array#8750.Rationale for this change
Added
append_arrayfn for the builderWhat changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are these changes tested?
We typically require tests for all PRs in order to:
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.