Conversation
There was a problem hiding this comment.
Maybe one note for this change. As I understand it, some take kernels are using to_usize while others are using as_usize. I've now used as_usize as it is also used in the take_native kernel.
Is there any guidelines on which operation we should use?
|
run benchmark take_kernels |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
Thanks again @tobixdev |
#19800) ## Which issue does this PR close? Adds a reproducer for #19067 and closes #19067. ## Rationale for this change The bug has been fixed in arrow-rs (apache/arrow-rs#8981). To ensure this case is covered in the tests, we add a reproducer. ## What changes are included in this PR? - SLT test case exhibiting the issue. DISCLAIMER: First version was generated using AI from the original reproducer and improved by me. Happy to incorporate further suggestions for improvements. ## Are these changes tested? Yes. I've also ensure that the test case exhibits the issue on `branch-51`. Diff when running the test on `branch-51`: ``` [Diff] (-expected|+actual) 1 aaaaaaaa aaaaaaaa 1000 2 bbbbbbbb bbbbbbbb 2000 - 3 cccccccc NULL NULL + 3 cccccccc aaaaaaaa NULL ``` ## Are there any user-facing changes? No
Includes fix for FixedSizeBinary LEFT JOIN bug - apache/arrow-rs#8981
Includes fix for FixedSizeBinary LEFT JOIN bug - apache/arrow-rs#8981 Cherry-picked test and API updates from - apache#19355
Includes fix for FixedSizeBinary LEFT JOIN bug - apache/arrow-rs#8981 Cherry-picked test and API updates from - apache#19355
Includes fix for FixedSizeBinary LEFT JOIN bug - apache/arrow-rs#8981 Cherry-picked test and API updates from - apache#19355
Which issue does this PR close?
take_fixed_size_binaryDoes Not Consider NULL Indices #8947Rationale for this change
I messed up @tobixdev 's PR / branch by accident in #8948
This PR contains the previous commits that were in that PR
What changes are included in this PR?
Are these changes tested?
Yes, by CI
Are there any user-facing changes?
Less bugs, faster code