arrow-data: avoid allocating in get_last_run_end#8974
Merged
Dandandan merged 1 commit intoapache:mainfrom Dec 10, 2025
Merged
Conversation
The previous code called Buffer::from to get typed_data, which allocates a new MutableBuffer. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiotto
force-pushed
the
asubiotto/runends
branch
from
878c1e3 to
7efea53
Compare
brancz
approved these changes
Dec 9, 2025
Contributor
|
cc @alamb |
Contributor
|
Thanks @brancz -- I feel like the review queue in arrow-rs is currently pretty big. I hope to spend time tomorrow working it down. We need to find some more review capacity somewhere |
alamb
approved these changes
Dec 9, 2025
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
makes sense to me -- thanks @asubiotto
Dandandan
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code called Buffer::from to get typed_data, which allocates a new MutableBuffer.
Which issue does this PR close?
I believe this PR is small enough to not require an issue.
Rationale for this change
Performance. This PR reduces allocations
What changes are included in this PR?
See commit
Are these changes tested?
By pre-existing tests
Are there any user-facing changes?
No