Support for Arc<str> in ParquetRecordWriter derive macro#8973
Merged
alamb merged 12 commits intoapache:mainfrom Dec 11, 2025
Merged
Support for Arc<str> in ParquetRecordWriter derive macro#8973alamb merged 12 commits intoapache:mainfrom
Arc<str> in ParquetRecordWriter derive macro#8973alamb merged 12 commits intoapache:mainfrom
Conversation
Co-authored-by: Ivan Reshetnikov <keenn2007@gmail.com>
fix: merge upstream changes
fix: cleanup & update from upstream
fix: update tests
Contributor
|
Thanks @heilhead -- this looks good to me |
alamb
approved these changes
Dec 10, 2025
fix: update from upstream 11.12.25
Contributor
Author
|
@alamb Sorry for the ping, but can you please review again or merge it yourself? I've updated our branch with the upstream changes and now it requires another approval. |
3 tasks
fix: update from upstream
Contributor
Author
|
@alamb Sorry for pinging again, but can you please merge the PR? By the time I get your approval it's behind |
Contributor
I will handle merging this PR once CI passes -- there is nothing else you need to do. Thank you for the contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Arc<str>inParquetRecordWriterderive macro #8972.Rationale for this change
See #8972 for more info.
What changes are included in this PR?
Updates the derive macro implementation to include string serialization from
Arc<str>.Are these changes tested?
Yes. I've updated
parquet_derive_testto include writingArc<str>. And we've been using our fork with these changes in production for ~3 years.Are there any user-facing changes?
Not sure, probably not?