Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions parquet-variant/src/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ use std::{borrow::Cow, ops::Deref};
/// assert_eq!(path, path3);
/// ```
///
/// # Example: From Dot notation strings
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My immediate question from this is "is there an escape mechanism to allow for "." in a field name?". I checked and the answer's no. That's fine but it might be worth a note.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do even better than that and instead 🎣 for real support:

/// ```
/// # use parquet_variant::{VariantPath, VariantPathElement};
/// /// You can also convert strings directly into paths using dot notation
/// let path = VariantPath::from("foo.bar.baz");
/// let expected = VariantPath::from("foo").join("bar").join("baz");
/// assert_eq!(path, expected);
/// ```
///
/// # Example: Accessing Compound paths
/// ```
/// # use parquet_variant::{VariantPath, VariantPathElement};
Expand Down
Loading