-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Variant] Support array shredding into List/LargeList/ListView/LargeListView
#8831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b89e32b
[Variant] Implement shredding variant array
liamzwbao b565107
Support LargeList and LargeListView
liamzwbao a34c5a5
Add comments
liamzwbao e481906
Merge branch 'main' into issue-8830-shred-list-variant
liamzwbao d0f1744
Rename variable for clarification
liamzwbao 29f26e5
Refactor tests with `build_variant_array`` helper
liamzwbao 6b17ca4
Merge branch 'main' into issue-8830-shred-list-variant
liamzwbao cde4fce
Refactor list test assertions
liamzwbao ca9fd49
Fix Clippy
liamzwbao bcaee04
Minor cleanup
liamzwbao 47470aa
Merge branch 'main' into issue-8830-shred-list-variant
liamzwbao 701fc48
Merge branch 'main' into issue-8830-shred-list-variant
liamzwbao bfc576e
Converge list and listView builders
liamzwbao dd9885d
Create TestListLikeArray instead of updating ListLikeArray
liamzwbao 342ee5c
Minor tweak
liamzwbao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.