Fix dark mode button #1371
Merged
Fix dark mode button #1371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
static check issues :) |
Contributor
Author
Aware of that, there are also other issues as well. Drafting until finalization. |
shahar1
force-pushed
the
fix-ui-fouc
branch
2 times, most recently
from
ba38a04 to
e5b6e98
Compare
Member
|
Nice! |
Contributor
Author
Unfortunately it didn't help that much, created an issue for that (see #1373). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request updates the dark mode initialization logic in
landing-pages/site/assets/js/dark-mode.jsto improve how the theme is stored and how the initialization is triggered. The most important changes are grouped below:Theme storage update:
'td-color-theme'to'theme', simplifying and standardizing the key used to store the user's theme preference.Initialization improvements:
initfunction, which is now called either immediately or after theDOMContentLoadedevent, depending on the document's readiness. This ensures the theme is applied consistently and avoids potential race conditions. [1] [2]