Fix: remove dots from expanded images #1368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
requested changes
Jan 3, 2026
Contributor
shahar1
left a comment
shahar1
left a comment
There was a problem hiding this comment.
We need to use only official releases, and the pointer that you suggested does not seem to be one, unfortunately. If the latest version fixes it and it doesn't break anything else - then we could proceed from there.
Author
|
Hey
Thanks for explaining!
I understand now that we need to use official Docsy releases only.
I’ll check whether the latest Docsy release already fixes this and update
accordingly.
…On Sat, 3 Jan 2026 at 20:19, Shahar Epstein ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We need to use only official releases
<https://github.com/google/docsy/releases>, and the pointer that you
suggested does not seem to be one, unfortunately. If the latest version
fixes it and it doesn't break anything else - then we could proceed from
there.
—
Reply to this email directly, view it on GitHub
<#1368 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDF5MBXVFKOHV5KZGGZBVMT4E7JJNAVCNFSM6AAAAACQQQYAGSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMRUGM3DANBSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
I’ve updated the Docsy submodule to point to the latest official release (v0.13.0). Please let me know if this resolves the issue correctly or if any further changes are needed. |
Member
Hmm. build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dots displayed under expanded images.
The dots were rendered via Bootstrap carousel indicators. The fix is implemented as a project-level SCSS override in the Docsy theme, without modifying Docsy core styles.
Only the Docsy submodule pointer is updated.
Fixes #222