Improve dark mode toggling and color constrast #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the landing pages with improved dark mode support, better color contrast for accessibility, and refined logo presentation across different themes. The changes focus on making the UI more consistent and readable in both light and dark modes, with special handling for company logos in testimonials and use cases.
Key changes:
- Relocate theme toggle from inside navigation to after navigation container for better positioning
- Enhance dark mode styling for dropdown menus with proper background colors and hover states
- Implement sophisticated logo filtering logic to ensure consistent grayscale appearance in default state and proper color restoration on hover for both light and dark modes
- Add dark-mode-specific logo variants for Sift and RancherBySUSE companies
- Improve text color contrast in community page accordions for better readability
Reviewed changes
Copilot reviewed 6 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sphinx_airflow_theme/sphinx_airflow_theme/header.html | Moves theme toggle outside navigation links container and changes icon class from opacity-50 to theme-icon |
| landing-pages/site/assets/scss/_navbar.scss | Repositions theme toggle button, adjusts dropdown alignment to right-side, adds dark mode dropdown styling, and hides duplicate toggle in mobile drawer |
| landing-pages/site/assets/scss/_list-boxes.scss | Implements complex filter chains for logo grayscale/color effects, adds dark-mode logo swapping logic for specific companies, and uses CSS blend modes for consistent appearance |
| landing-pages/site/layouts/partials/boxes/testimonial.html | Adds conditional dark-mode logo elements for Rancher SUSE and Sift with class-based visibility toggling |
| landing-pages/site/assets/scss/_community-page.scss | Improves text color contrast for accordion content in dark mode |
| landing-pages/site/static/usecase-logos/*.svg | Adds/updates SVG logos including dark mode variants and converts some logos from PNG to SVG format |
| landing-pages/site/content/en/use-cases/sift.md | Updates logo reference from PNG to SVG format |
| landing-pages/site/static/usecase-logos/download-idR6yyb4TP-1766854345548.zip | Binary ZIP file accidentally committed to repository |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shahar1
force-pushed
the
improve-dark-mode-toggling-and-color-constrast
branch
4 times, most recently
from
3d0892a to
ae05e85
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 17 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shahar1
force-pushed
the
improve-dark-mode-toggling-and-color-constrast
branch
from
ae05e85 to
35721a0
Compare
shahar1
changed the title
shahar1
force-pushed
the
improve-dark-mode-toggling-and-color-constrast
branch
from
35721a0 to
eb2d952
Compare
shahar1
commented
Dec 27, 2025
Comment on lines
+27
to
32
| {{ if eq $title "RancherBySUSE" }} | ||
| <img class="logo-dark-mode" src="/usecase-logos/rancher-suse-white.svg" alt="{{ $title }} logo" /> | ||
| {{ end }} | ||
| {{ if eq $title "Sift" }} | ||
| <img class="logo-dark-mode" src="/usecase-logos/sift_logo_white.svg" alt="{{ $title }} logo" /> | ||
| {{ end }} |
Contributor
Author
There was a problem hiding this comment.
I'm aware that it's quite hardcodish - I prefer to deal with it later, if and when we manage to add more testimonials :)
shahar1
commented
Dec 27, 2025
Comment on lines
+26
to
+33
| <img src="/usecase-logos/{{ . }}" alt="{{ $title }} logo" class="quote--logo logo-default" /> | ||
| {{ end }} | ||
| {{ if eq $title "RancherBySUSE" }} | ||
| <img class="quote--logo logo-dark-mode" src="/usecase-logos/rancher-suse-white.svg" alt="{{ $title }} logo" /> | ||
| {{ end }} | ||
| {{ if eq $title "Sift" }} | ||
| <img class="quote--logo logo-dark-mode" src="/usecase-logos/sift-logo-white.svg" alt="{{ $title }} logo" /> | ||
| {{ end }} |
potiuk
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copilot Summary
This pull request introduces several improvements to the styling and behavior of the landing pages, focusing on enhanced color contrast for readability, and better navigation bar appearance and usability. The changes ensure consistent testimonials logos presentation in both light and dark modes, improve accessibility and readability, and refine the user interface for dropdowns and navigation elements.
Improved color contrast and readability
Before:
After:
Navigation bar and dropdown menu improvements:
Before:
Small devices
Large devices
After:
Small devices
Large devices
Use case and testimonials
Before:
After:
