Skip to content

Fix antrun for openwire-generate and allow (require) JDK8 for now #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbonofre wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −2
Open

Fix antrun for openwire-generate and allow (require) JDK8 for now #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions activemq-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@

<profiles>
<!-- Execute with: mvn -P openwire-generate antrun:run -->
<!-- NB: this requires JDK8 still -->
<profile>
<id>openwire-generate</id>
<build>
Expand All @@ -340,11 +341,11 @@
</execution>
</executions>
<configuration>
<tasks>
<target>
<echo>Running OpenWire Generator</echo>
<taskdef name="generate" classname="org.apache.activemq.openwire.tool.JavaGeneratorTask" classpathref="maven.compile.classpath" />
<generate version="12" basedir="${basedir}" generateTests="false" />
</tasks>
</target>
</configuration>
<dependencies>
<dependency>
Expand Down
37 changes: 37 additions & 0 deletions activemq-openwire-generator/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
<artifactId>activemq-openwire-generator</artifactId>
<name>ActiveMQ :: Openwire Generator</name>

<properties>
<maven.compiler.target>8</maven.compiler.target>
</properties>

<dependencies>
<dependency>
<groupId>org.apache.groovy</groupId>
Expand All @@ -51,6 +55,39 @@

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<executions>
<execution>
<id>enforce-maven</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireMavenVersion>
<version>3.0.5</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
<execution>
<id>enforce-java-version</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>[8,)</version>
Copy link
Contributor

@cshannon cshannon Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will allow java 8 or higher, is that what you want? Doesn't this break when running with newer JDKs which was the problem?

Copy link
Member Author

@jbonofre jbonofre Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. We should probably be more "restrictive" here. Let me update.

<message>You must use Java 8 to build.</message>
</requireJavaVersion>
</rules>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
Expand Down
Loading