Modified movement onset function #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
resatomo
commented
Jan 12, 2026
resatomo
commented
- Low-pass filter cursor position before speed is estimated because the cursor position is sometimes jittered by optitrack issues
- Update docstrings
mtringi
reviewed
Jan 12, 2026
| init_pos_trial ((ntr, 3), optional) : If initial target position is different for each trial, | ||
| you should specify initial target position (x,y,z coordinates) for each trial. If you don't specify init_pos_trial, | ||
| this function assume that initial target positon is always the origin (0,0,0). (default is None) | ||
| butter_order (int or list, optional) : the order for the butterworth filter. If it is a list, the first element is used for |
Collaborator
There was a problem hiding this comment.
maybe add note that list should not be greater than 2 values?
mtringi
reviewed
Jan 12, 2026
aopy/analysis/behavior.py
Outdated
| speed_tmp = np.diff(dist)/(1/fs) | ||
| speed_tmp = np.insert(speed_tmp,0,speed_tmp[0]) # complement the first data point | ||
| speed = signal.filtfilt(b, a, speed_tmp, axis=0) | ||
| speed = signal.filtfilt(b2, a2, speed_tmp, axis=0) |
Collaborator
There was a problem hiding this comment.
Would it be useful to also return the speed profile of each trial since it is already being calculated?
mtringi
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.