add inh poisson model for spikes #701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcanfield2
reviewed
Aug 9, 2025
aopy/analysis/latency.py
Outdated
Comment on lines
286
to
287
| rate1: (nt,) array, mean rate for model 1 (Hz) | ||
| rate2: (nt,) array, mean rate for model 2 (Hz) |
Collaborator
There was a problem hiding this comment.
If these are just mean rates, should they be arrays or float/ints?
rcanfield2
approved these changes
Aug 9, 2025
Collaborator
rcanfield2
left a comment
rcanfield2
left a comment
There was a problem hiding this comment.
Can you just add some labels to your plots?
rcanfield2
reviewed
Oct 30, 2025
aopy/analysis/latency.py
Outdated
Comment on lines
290
to
291
| rate1: (nt,): rate model 1 | ||
| rate2: (nt,): rate model 2 |
Collaborator
There was a problem hiding this comment.
Can you add a little more description to these. I'm not sure what the description means and how it is different from "spike_trial"
rcanfield2
reviewed
Oct 30, 2025
aopy/precondition/base.py
Outdated
| binned_spikes = binned_spikes/bin_width # convert from [spikes/bin] to [spikes/s] | ||
| return binned_spikes | ||
|
|
||
| def smooth_spike_raster(raster, fs, smoothing_window=0.005): |
Collaborator
There was a problem hiding this comment.
Is this different from aopy.postproc.smooth_timeseries_guas()?
https://analyze.readthedocs.io/en/latest/postproc.html#aopy.postproc.base.smooth_timeseries_gaus
Collaborator
Author
There was a problem hiding this comment.
they are the same! thanks for finding that
rcanfield2
reviewed
Oct 30, 2025
Collaborator
rcanfield2
left a comment
rcanfield2
left a comment
There was a problem hiding this comment.
just a couple comments/questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.