Skip to content

Conversation

@sijia66
Copy link
Collaborator

@sijia66 sijia66 commented Dec 17, 2024

No description provided.

Copy link
Collaborator Author

@sijia66 sijia66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a code example to use lasso feature selection for selecting neural features. Some questions to consider before merging back to the main branch.

  1. where to store the test data?
  2. SImilar functions in aopy?

@sijia66 sijia66 marked this pull request as ready for review December 17, 2024 17:42
@sijia66 sijia66 requested a review from leoscholl December 17, 2024 17:43
@leoscholl
Copy link
Collaborator

looks really useful, and seems that you identified some functions that could be added to aopy! i think lasso_main, get_selected_unselected_electrodes and especially plot_electrode_selection would be great additions; please make PRs for those separately when you have time.
i don't think you need to include the test data, that would be better suited to go along with your paper.

Copy link
Collaborator

@leoscholl leoscholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useful, thanks for removing the test data. I'll make an issue that reminds us to migrate these functions into aopy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants