Pavi centerout postproc #553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoscholl
reviewed
Jun 21, 2024
Comment on lines
+201
to
+211
| # Transformation matrix | ||
| T = np.array([ | ||
| [0, 0, 1], | ||
| [0, 1, 0], | ||
| [1, 0, 0] | ||
| ]) | ||
|
|
||
| # Perform the matrix multiplication | ||
| h_coords = o_coords.dot(T) | ||
|
|
||
| return h_coords |
Collaborator
There was a problem hiding this comment.
shouldn't this also include the offset and scale portion of the full _transform_coords()?
leoscholl
reviewed
Dec 19, 2024
Collaborator
leoscholl
left a comment
leoscholl
left a comment
There was a problem hiding this comment.
get_mapping and transform_coords are implemented in #594
- it would be great to make a new PR with the images you made describing the various coordinate systems. we defined "raw" coordinate system to mean the coordinate system used by inputs like optitrack, the "bmi3d" coordinate system with y/z flipped, the "screen" coordinate system that is xyz=right/up/into the screen, and the "world" coordinate system xyz=right/up/forwards for the user.
- it would also be great to add get_taskspace_and_nullspace and decompose_hand_movements to aopy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is work in progress. I added a centerout.py file in postproc to include functions related to getting the mapping used and perform coordinate transformations.
Need to write test cases for all functions in centerout.py. I have included test cases for coordinate transformation functions. those two can be merged.