Feature/7802 elasticsearch alias #236
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
to draft until @HavierD is back from holiday |
utas-raymondng
requested changes
Jan 12, 2026
| } | ||
| } | ||
|
|
||
| protected Set<String> extractTokensFromDescription(String description) throws IOException { |
Contributor
There was a problem hiding this comment.
This function isn't in use except test, is that we can delete it and my the test case?
Contributor
Author
There was a problem hiding this comment.
i added an overload function of this function, so it made this function not in use. Yes i will remove it with its tests.
| } | ||
| } | ||
|
|
||
| public List<String> getAllIndicesWithPrefix(String baseIndexName) { |
Contributor
There was a problem hiding this comment.
Can change to protected without issue
| * @param existingIndices list of existing index names | ||
| * @return next available version number | ||
| */ | ||
| public int getAvailableVersionNumber(List<String> existingIndices) { |
Contributor
There was a problem hiding this comment.
- Can change to protected without issue
- Is it necessary to keep a version number in the name or a random string works, it seems less complicate if version _vxxx is not needed or you use a date instead if you really want some kind of bookmark
- What happen if the index failed in the middle, will the cleanup clean the previous incomplete index
- Any test to verify alias flip?
- I think the code have clean the old index right?
Contributor
Author
There was a problem hiding this comment.
- ok
- We need some suffix to differentiate indexes so that we can do things such as rollback etc.. version number is not necessary. It can be a datetime string to make it easier.
- nothing happened for now. only succeeded index will be in use. if an indexing is failed, the old index is still in use. No any index will be clean for now. We may need to discuss a cleanup rule later, because we need to keep several old indexes and incomplete/error indexes sometimes, for debugging, rollback, etc..
- will check later. if no, i will add one.
- as above NO.3 said, not for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.