fix login issue #143

Miduo666 · 2025-12-12T12:58:08Z

Pull Request Details

What issue does this PR address

[Description]

Associated Issue

This PR relates to issue #

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

Finalising

Once PR discussion is complete and reviewers have approved:

Merge dev into the this branch
Resolve any conflicts
Add a one line summary into the CHANGELOG.md
Push to the git repository and review
Merge the PR into dev

Miduo666 · 2025-12-13T01:33:21Z

Summary

This PR fixes critical login and authentication issues in the solidui package.

Key Fixes

Login Form State Loss: Fixed TextEditingController being recreated on every build, which caused user input to disappear.
Double-Slash Path Bug: Fixed file paths like //data/places.json when returning from guest mode by properly resetting appDirName.
Server Connection Errors: Added error handling with informative dialog when authentication server is unavailable.
Tab State Preservation: Switched to IndexedStack to prevent widget rebuilds and preserve scroll position.
Security Key Access: Added login check before showing security key manager.

tonypioneer · 2025-12-15T10:43:02Z

Hi @lambadajester50-byte, could you please describe in brief what issue have you fixed in this PR? Thank you very much.

Miduo666 · 2025-12-16T09:05:12Z

Hi @lambadajester50-byte, could you please describe in brief what issue have you fixed in this PR? Thank you very much.

Thank you! I‘ve fixed a login bug described in gjwgit/geopod#13

tonypioneer · 2025-12-16T12:16:41Z

Hi @lambadajester50-byte, I did a round of test.

After I tapped Continue and Not logged in, the page jumped to the login page of SolidPod.

Then I clicked on Continue again, it showed Authentication required in red text, and the background is transparent.

Miduo666 · 2025-12-16T12:25:24Z

Hi Tony @tonypioneer ,
Thanks for the feedback. Regarding the "Authentication required" error and the UI issues, I believe this is due to version mismatches between the interdependent packages.
To fix this, we likely need to ensure all related packages are updated to their latest development versions. Could you try adding the following dependency_overrides at the end of your pubspec.yaml?
This will force the project to use the consistent dev branches for all Solid components:
dependency_overrides:
solidpod:
git:
url: https://github.com/lambadajester50-byte/solidpod.git
ref: dev
solid_auth:
git:
url: https://github.com/lambadajester50-byte/solid_auth.git
ref: dev
solidui:
git:
url: https://github.com/lambadajester50-byte/solidui.git
ref: dev

tonypioneer · 2025-12-16T12:38:39Z

Hi Tony @tonypioneer , Thanks for the feedback. Regarding the "Authentication required" error and the UI issues, I believe this is due to version mismatches between the interdependent packages. To fix this, we likely need to ensure all related packages are updated to their latest development versions. Could you try adding the following dependency_overrides at the end of your pubspec.yaml? This will force the project to use the consistent dev branches for all Solid components: dependency_overrides: solidpod: git: url: https://github.com/lambadajester50-byte/solidpod.git ref: dev solid_auth: git: url: https://github.com/lambadajester50-byte/solid_auth.git ref: dev solidui: git: url: https://github.com/lambadajester50-byte/solidui.git ref: dev

Hi @lambadajester50-byte, thanks for the quick reply. I added the depedencies to the override section, and ran flutter pub get and flutter pub upgrade before running the app. But the issue is still there.

Miduo666 · 2025-12-16T15:42:31Z

Hi @lambadajester50-byte, thanks for the quick reply. I added the depedencies to the override section, and ran flutter pub get and flutter pub upgrade before running the app. But the issue is still there.

Hi @tonypioneer
I apologize for the confusion. It turns out some specific configurations required for the UI were missing in the base packages—I had them locally in geopod when they actually should have been integrated into solidui.

I have now refactored the code, fixed the configuration issue, and pushed the updates to the repository. I’ve tested the entire flow on Web, and everything is now working perfectly on my end.

Please pull the latest changes, run flutter pub get again, and give it another try. Let me know if it works for you!

tonypioneer

Thanks @lambadajester50-byte. I did a round of test. The functionality works well now. Please resolve the conflicts against the dev branch, and lint the code. Because in the code style guidelines of the SII, a blank line before and after a comment is recommended. The exception is at the beginning of a block which lint usually enforces (https://survivor.togaware.com/gnulinux/flutter-style-comments.html).

Miduo666 · 2025-12-19T09:33:23Z

Thanks @lambadajester50-byte. I did a round of test. The functionality works well now. Please resolve the conflicts against the dev branch, and lint the code. Because in the code style guidelines of the SII, a blank line before and after a comment is recommended. The exception is at the beginning of a block which lint usually enforces (https://survivor.togaware.com/gnulinux/flutter-style-comments.html).

I‘ve done! Thank you Tony!

tonypioneer · 2026-01-12T10:07:15Z

Hi @Miduo666, I think there are some conflicts in the code with the dev branch.

Miduo666 · 2026-01-12T10:24:26Z

Hi @Miduo666, I think there are some conflicts in the code with the dev branch.

Thank you Tony, I 'll merge dev into this PR soon

tonypioneer · 2026-01-12T10:25:26Z

Hi @Miduo666, I think there are some conflicts in the code with the dev branch.

Thank you Tony, I 'll merge dev into this PR soon

Thanks @Miduo666.

tonypioneer

Hi @Miduo666, thanks for the fix.

I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.

Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)

lib/src/widgets/solid_security_key_manager.dart

Miduo666 · 2026-01-12T13:16:20Z

Hi @Miduo666, thanks for the fix.

I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.

Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)

Hi Tony, it's fixed now. I've also enabled login support for the example project, so it's all good to go.

tonypioneer · 2026-01-13T11:47:57Z

Hi @Miduo666, thanks for the fix.
I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.

Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)

Hi Tony, it's fixed now. I've also enabled login support for the example project, so it's all good to go.

Thanks @Miduo666. Please merge dev to your branch again. There are still some conflicts.

Miduo666 · 2026-01-13T16:54:23Z

Hi @Miduo666, thanks for the fix.
I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.
Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)
Hi Tony, it's fixed now. I've also enabled login support for the example project, so it's all good to go.
Thanks @Miduo666. Please merge dev to your branch again. There are still some conflicts.

Done. Thank you Tony!

tonypioneer · 2026-01-14T06:38:27Z

Hi @Miduo666, thanks for the fix.
I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.
Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)
Hi Tony, it's fixed now. I've also enabled login support for the example project, so it's all good to go.
Thanks @Miduo666. Please merge dev to your branch again. There are still some conflicts.
Done. Thank you Tony!

Thanks @Miduo666. I think there are still some conflicts. Maybe the dev branch is updated too frequently.

Miduo666 · 2026-01-14T10:03:13Z

Hi @Miduo666, thanks for the fix.
I did a round of test, the functionality works well on my machine. However, when I ran make prep to do the lint check, there were some minor issues as below.
Dart: FIX IMPORT ORDER
❌ Import ordering issues found in lib/src/widgets/solid_status_bar.dart:
   • Import 'package:solidpod/solidpod.dart' should come before 'package:gap/gap.dart' (alphabetical order)
   • Missing blank lines between different import groups

📝 Summary: Found import ordering issues in 1 file(s).
💡 To fix these issues, run the same command without --set-exit-if-changed

Successfully fixed import ordering in 202 file(s).
------------------------------------------------------------------------
Dart: REVIEW DEPENDENCIES.
dependency_validator

Validating dependencies for solidui...
These packages are used outside lib/ but are not dev_dependencies:
  * flutter_test
  * myapp
These packages may be unused, or you may be using assets from these packages:
  * web
make: [depend] Error 1 (ignored)
Hi Tony, it's fixed now. I've also enabled login support for the example project, so it's all good to go.
Thanks @Miduo666. Please merge dev to your branch again. There are still some conflicts.
Done. Thank you Tony!
Thanks @Miduo666. I think there are still some conflicts. Maybe the dev branch is updated too frequently.

Yeah it is. Fortunately I ve resolved the conflicts @tonypioneer

tonypioneer

Works well on my machine. Thanks @Miduo666.

tonypioneer · 2026-01-12T12:19:13Z

lib/src/utils/file_operations.dart

-      if (!fileName.endsWith('.enc.ttl') && !fileName.endsWith('.ttl')) {
+      // Skip ACL files and metadata files, but include all other file types
+      // (TTL, JSON, CSV, TXT, etc.)
+      if (fileName.endsWith('.acl') || fileName.endsWith('.meta')) {


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

tonypioneer · 2026-01-12T12:19:20Z

lib/src/widgets/solid_dynamic_login_status.dart

        _currentWebId != null && _currentWebId!.isNotEmpty;

    if (isCurrentlyLoggedIn) {
+      // Logout scenario - don't recheck status as page will reload


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

tonypioneer · 2026-01-12T12:19:24Z

lib/src/widgets/solid_dynamic_login_status.dart

        SolidAuthHandler.instance.handleLogout(context);
      }
    } else {
+      // Login scenario - can delay status check


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

tonypioneer · 2026-01-12T12:19:28Z

lib/src/widgets/solid_dynamic_login_status.dart

-        _checkLoginStatus();
-      }
-    });
+      // Only refresh status for login scenario


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

tonypioneer · 2026-01-12T12:20:09Z

lib/src/widgets/solid_login.dart

    WidgetsBinding.instance.addObserver(this);
    solidThemeNotifier.addListener(_onThemeChanged);

+    // Initialize the controller with the widget's webID


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

Please use British English.

tonypioneer · 2026-01-12T12:21:52Z

lib/src/widgets/solid_login_helper.dart

-    context,
+  // Use simple pushReplacement instead of pushAndRemoveUntil
+  // This preserves the navigation history and doesn't destroy all widgets
+  await Navigator.of(context).pushReplacement(


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

tonypioneer · 2026-01-12T12:21:57Z

lib/src/widgets/solid_logout_dialog.dart

            if (await logoutPod()) {
+              // Navigate to login page after successful logout
+              // Works consistently across all platforms
              if (context.mounted) {


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

lib/src/widgets/solid_status_bar.dart

tonypioneer · 2026-01-12T12:22:47Z

lib/src/widgets/solid_status_bar.dart

+  ) async {
+    // Import at top: import 'package:solidpod/solidpod.dart' show getWebId;
+    // Check if user is logged in first
+    try {


Please add an empty line after the comment. Ref: https://survivor.togaware.com/gnulinux/flutter-style-comments.html

lib/src/widgets/solid_status_bar.dart

Miduo666 added 11 commits December 9, 2025 23:02

new

8751446

new

70a947e

new

8b40173

new

8a2e815

new

03ab4d5

new

fda7957

new

67a3939

new

d2ec702

new

4b135a6

new

44fd9b7

new

617de91

Miduo666 added 4 commits December 13, 2025 12:59

new

c8abf7f

new

6d22721

new

d936549

new

e830ee4

new

2f96bbb

tonypioneer self-requested a review December 16, 2025 12:39

new

ec478aa

tonypioneer requested changes Dec 17, 2025

View reviewed changes

new

be59177

Miduo666 requested a review from tonypioneer December 19, 2025 09:31

all_fixed

293c5dc

Miduo666 added 8 commits December 25, 2025 15:39

new

1b4861e

new

ec42754

new

7e32c93

new

ea6be28

new

35b0a3d

new

3cf1ac0

new

1d8bb14

fix_issue_overflow

e0b9292

merge dev

0f78914

tonypioneer requested changes Jan 12, 2026

View reviewed changes

lib/src/widgets/solid_security_key_manager.dart Show resolved Hide resolved

Miduo666 added 3 commits January 12, 2026 20:48

fix_issue

2eca185

add_support_example_login

9655019

format_issue

8721568

gjwgit self-requested a review January 12, 2026 23:06

merge dev

f02fdc9

resolve import order

8b94958

merge_dev

c6e0e30

tonypioneer added 4 commits January 14, 2026 23:36

Lint

25c4cac

Lint

4c63276

Lint

c732c7b

Lint

48fbe42

tonypioneer approved these changes Jan 14, 2026

View reviewed changes

fix login issue #143

Are you sure you want to change the base?

fix login issue #143

Conversation

Miduo666 commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Details

What issue does this PR address

Associated Issue

Type of Change

How Has This Been Tested?

Checklist

Finalising

Uh oh!

Miduo666 commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Fixes

Uh oh!

tonypioneer commented Dec 15, 2025

Uh oh!

Miduo666 commented Dec 16, 2025

Uh oh!

tonypioneer commented Dec 16, 2025

Uh oh!

Miduo666 commented Dec 16, 2025

Uh oh!

tonypioneer commented Dec 16, 2025

Uh oh!

Miduo666 commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonypioneer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Miduo666 commented Dec 19, 2025

Uh oh!

tonypioneer commented Jan 12, 2026

Uh oh!

Miduo666 commented Jan 12, 2026

Uh oh!

tonypioneer commented Jan 12, 2026

Uh oh!

tonypioneer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Miduo666 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tonypioneer commented Jan 13, 2026

Uh oh!

Miduo666 commented Jan 13, 2026

Uh oh!

tonypioneer commented Jan 14, 2026

Uh oh!

Miduo666 commented Jan 14, 2026

Uh oh!

tonypioneer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Miduo666 commented Dec 12, 2025 •

edited

Loading

Miduo666 commented Dec 13, 2025 •

edited

Loading

Miduo666 commented Dec 16, 2025 •

edited

Loading

tonypioneer left a comment •

edited

Loading

Miduo666 commented Jan 12, 2026 •

edited

Loading