Skip to content

Conversation

@anushkavidanage
Copy link
Collaborator

Pull Request Details

What issue does this PR address

  • Create custom folders inside the data folder at the initialisation stage

Associated Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

Copy link
Contributor

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest split misc.dart into separate files.

@anushkavidanage
Copy link
Collaborator Author

I've relocated few functions from misc.dart to multiple files now.

@gjwgit
Copy link
Contributor

gjwgit commented Jan 14, 2026

Not sure I understand why, but I now get:

2026-01-14 12:21:30 gjw@kadesh ~/pro/solidpod$ make locmax
Files with EXCESS LINES OF CODE:

 338 lib/src/solid/grant_permission_ui.dart
 305 lib/src/solid/utils/misc.dart
 302 lib/src/solid/utils/key_manager.dart

Total 6565 lines of code across 62 files.

❌ Error: Found 3 files with more than 300 lines of code.
make: [support/flutter.mk:224: locmax] Error 1 (ignored)

@anushkavidanage
Copy link
Collaborator Author

@gjwgit I merged dev to this branch which includes Jess's latest changes to grant permission functions. Might be coming from there. Will have a look.

@gjwgit gjwgit merged commit c6f6db8 into dev Jan 14, 2026
18 of 20 checks passed
@gjwgit gjwgit deleted the av/522_custom_folder_structure_at_initialisation_stage branch January 14, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants