-
Notifications
You must be signed in to change notification settings - Fork 7
Jess/509 share ext res #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gjwgit This PR ready for review. Sorry, the last 2 commits for this PR were inadvertently merged into dev instead of this branch. They updated the GrantPermissionUI examples in README.md and added an assertion check to GrantPermissionUI parameters (that externalWebId is provided if isExternalRes). Then merged dev into the pr branch to resolve conflicts. Those commits can stay in dev, if this PR is approved and merged. |
anushkavidanage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Jess.
Pull Request Details
What issue does this PR address
Associated Issue
Type of Change
How Has This Been Tested?
Tested in iOS in notepod app. Login as user that is a recipient (but not owner of a file). Share the file to a third party (individual or group recipient options provided).
Checklist
Complete the check-list below to ensure your branch is ready for PR.
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising
Once PR discussion is complete and reviewers have approved: