Skip to content

Conversation

@jesscmoore
Copy link
Collaborator

@jesscmoore jesscmoore commented Jan 9, 2026

Pull Request Details

What issue does this PR address

  • This PR is explicitly specifies the owner and granter webId in functions that grant or revoke permissions to ensure that correct permission log entries are written for permission changes of user owned and externally owned files (that the user has control access to).
  • It also clarifies function doc string and ambiguous variable names in grant / revoke functions.
  • This PR relates to issue SOLIDPOD: update revoking permissions to update granter permission log #466

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist

Complete the check-list below to ensure your branch is ready for PR.

  • Screenshots included in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

Once PR discussion is complete and reviewers have approved:

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore jesscmoore marked this pull request as ready for review January 12, 2026 13:01
@jesscmoore jesscmoore requested a review from gjwgit January 12, 2026 13:14
Copy link
Collaborator

@anushkavidanage anushkavidanage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working well. Thanks Jess.

@gjwgit gjwgit merged commit 5e17112 into dev Jan 14, 2026
18 of 20 checks passed
@gjwgit gjwgit deleted the jess/466_update_granter_log branch January 14, 2026 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants