Fix total_delta incorrect parse (ignoring null values)#51
Open
MariaJoaoMiraPaulo wants to merge 1 commit intoanuraag016:masterfrom
Open
Fix total_delta incorrect parse (ignoring null values)#51MariaJoaoMiraPaulo wants to merge 1 commit intoanuraag016:masterfrom
MariaJoaoMiraPaulo wants to merge 1 commit intoanuraag016:masterfrom
Conversation
Fix total_delta parse error: total_delta default value as null was being ignored and, instead, total_delta was always parsed to 0.
MariaJoaoMiraPaulo
force-pushed
the
total-delta-incorrect-parse
branch
from
be1403b to
b127e92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
total_deltaparse error.When total_delta is not passed to the action, it should hold the null - the default value - inheriting the delta value in
checkIfTestCoverageFallsBelowDeltamethod.However, since getInput returns an empty string and not a null value, total_delta is attributed with the result of
Number("")which is 0, and hence, total_delta never inherits the given delta value.