Skip to content

Project 2 Feedback#149

Open
r-pears wants to merge 1 commit intoantxhan:mainfrom
r-pears:feedback
Open

Project 2 Feedback#149
r-pears wants to merge 1 commit intoantxhan:mainfrom
r-pears:feedback

Conversation

@r-pears
Copy link

@r-pears r-pears commented Feb 23, 2025

Really awesome job! Your app looks great.

  • Clean design.
  • User friendly.
  • Responsive.
  • Detailed.
  • Great file structure.
  • Great user experience.
  • Skeleton loader looks awesome.

Comments, feedback, and best practices in the PR.

Additional feedback:

  • Remove some unused boilerplate stuff that comes out of the box with React.
  • Remove unused stuff: comments, files, and imports.
  • Try and write with reusability in mind, either make a component big with many different use cases covered (I created a couple examples, Button.jsx and PlaylistDialog.jsx), or the components really small building blocks.
  • <Layout> could have been moved higher in the tree instead of added everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant