Offset only for the first setCurrentItem#43
Open
nolsigan wants to merge 5 commits intoantonyt:masterfrom
Open
Conversation
| } | ||
| item = getOffsetAmount() + (item % getAdapter().getCount()); | ||
| // offset only for the first time | ||
| if (item < getOffsetAmount()) |
There was a problem hiding this comment.
If the first action is to scroll back the offset is still added.
I would recommend to get half of offset amount
if (item < getOffsetAmount() / 2)
eg. when offset is 1000 and you scroll back - the function returns 1999 it would be better to return 999
Author
There was a problem hiding this comment.
Wow, I missed back scroll part. I fixed it as you recommended. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to do stuffs like auto scrolling,
setCurrentItem has to be used for every auto scroll.
Current version of setCurrentItem can't be used more than once because it adds offset to item every time.
This pull request resolves the issue.