Skip to content

Update xss-example.js #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antonychiu2 wants to merge 1 commit into
base: Snyk
Choose a base branch
from
Open

Update xss-example.js #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xss-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var urlParams = new URLSearchParams(window.location.search);
var name = urlParams.get('name');

var unsafe_div = window.document.getElementById("vulnerable-div");
unsafe_div.innerHTML = "Hello " + name;
var unsafe_div = window.document.getElementById("vulnerable-div");
unsafe_div.innerHTML = "Hello " + name;
Copy link

@github-actions github-actions bot Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image XSS fix is ready

Apply the following code change to fix XSS issue detected by Snyk:

diff --git a/xss-example.js b/xss-example.js
--- a/xss-example.js
+++ b/xss-example.js
@@ -2,4 +2,4 @@
 var name = urlParams.get('name');
 
 var unsafe_div = window.document.getElementById("vulnerable-div"); 
-unsafe_div.innerHTML = "Hello " + name;  
+unsafe_div.textContent = "Hello " + name;


Learn more and fine tune the fix