Multi-target .NET Standard 2.0 and .NET Framework 4.5#118
Open
WilStead wants to merge 1 commit intoantmicro:masterfrom
Open
Multi-target .NET Standard 2.0 and .NET Framework 4.5#118WilStead wants to merge 1 commit intoantmicro:masterfrom
WilStead wants to merge 1 commit intoantmicro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds multi-targeting for
netstandard2.0andnet45, in order to support use of Migrant in .NET Standard projects.Summary of changes:
slnandcsprojfiles are updated to the VS2017 format to permit the .NET Standard multi-targeting, including moving info fromAssemblyInfo.csto the project files.DumpToLibrary<T>inGenerators/GeneratorHelper.cs. This method is unused internally, even by tests. Compiler conditionals are used to restrict its use to thenet45target; for thenetstandard2.0target an Obsolete attribute is added and the method throws aNotImplementedExceptionif called.All tests verified passing after the changes.