Skip to content

fix(shell-plugin): add vi-command mode bindings for zsh-vi-mode compatibility #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
i010542 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shell-plugin): add vi-command mode bindings for zsh-vi-mode compatibility #2684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions shell-plugin/lib/bindings.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,14 @@ bindkey '^M' forge-accept-line
bindkey '^J' forge-accept-line
# Update the Tab binding to use the new completion widget
bindkey '^I' forge-completion # Tab for both @ and :command completion

# Fix: zsh-vi-mode plugin compatibility
# When zsh-vi-mode (jeffreytse/zsh-vi-mode) is active, Enter in vi-command mode
# does not trigger forge's colon commands. Fix by also binding Enter in vicmd.
# Detects both zsh-vi-mode plugin ($ZVM_MODE) and native vi mode (bindkey -v).
if [[ -n "$ZVM_MODE" ]] || bindkey -lL main 2>/dev/null | grep -q "bindkey -A viins main\|bindkey -A vicmd main"; then
bindkey -M vicmd '^M' forge-accept-line
bindkey -M vicmd '^J' forge-accept-line
# Also bind Tab in vicmd for @ and :command completion
bindkey -M vicmd '^I' forge-completion
fi
Loading