fix: use correct fallback type for reviewData in fetcher#1034
Open
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Open
fix: use correct fallback type for reviewData in fetcher#1034MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
MaxwellCalkin wants to merge 1 commit intoanthropics:mainfrom
Conversation
The reviewData variable is typed as `{ nodes: GitHubReview[] } | null`,
but the fallback value was `[]` (a plain array). When
`pullRequest.reviews` is null/undefined, `reviewData` becomes `[]`,
causing `reviewData.nodes` to return `undefined` instead of `[]`.
This leads to silent failures in downstream code that iterates over
`reviewData.nodes`, such as `filterReviewsToTriggerTime` and
`filterCommentsByActor`.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reviewDatais typed as{ nodes: GitHubReview[] } | nullbut the fallback on line 302 was[](a plain array), causing a type mismatch whenpullRequest.reviewsis nullishpullRequest.reviewsis null/undefined,reviewData.nodesreturnsundefinedinstead of[], breaking downstream iteration infilterReviewsToTriggerTimeandfilterCommentsByActor[]to{ nodes: [] }to match the declared typeTest plan
bun run typecheckpasses cleanlydata-fetcher.test.tstests passpullRequest.reviewsis present🤖 Generated with Claude Code