-
Notifications
You must be signed in to change notification settings - Fork 2
Adding more KMP targets #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more KMP targets #193
Conversation
342db2e to
9a2a5dd
Compare
| } | ||
| } | ||
| dependencyResolutionManagement { | ||
| repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the WASM/JS stuff setup some repositories behind the scenes which is not compatible with this setting.
| package com.anthonycr.mockingbird.core | ||
|
|
||
| import org.junit.Test | ||
| import kotlin.test.Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No junit now in commonTest
| class FakesKtTest { | ||
|
|
||
| @Test | ||
| fun `inline fake throws exception when there is no gradle plugin applied`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to an issue with backticks in method names and Kotlin/JS. It should be fixed though and once we bump the language level above 2.1 we can revert this change.
9a2a5dd to
6944f92
Compare
5997766 to
7b76239
Compare
7b76239 to
38c1cd6
Compare
|
will get to this tomorrow, didn't have time to get xcode set up yet |
|
finally got xcode setup and installed, looks great! merging. |
Replaces #68. Now that the compiler plugin stuff is merged this is now unblocked.
More KMP targets were initially blocked by #86 but now that Mockingbird is a compiler plugin it should be able to support all KMP targets 🎉
Some noteworthy changes/implications:
commonMain. I created ajvmMaindirectory which still uses Java reflection to avoid breaking any usages when upgrading.