Skip to content

Conversation

@nedchu
Copy link
Collaborator

@nedchu nedchu commented Jun 23, 2025

closes: #831

nedchu added 2 commits June 10, 2025 23:19
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
…ompressed graph in deserial

Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
nedchu added 2 commits June 23, 2025 14:45
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
for (InnerIdType id = 0; id < this->max_capacity_; ++id) {
GraphDataCell::InsertNeighborsById(id, empty_ids);
}
}
Copy link
Collaborator Author

@nedchu nedchu Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When building a compressed graph from normal graph datacell, the prograph will go wrong if the neighbor set is not initialized by InsertNeighborsById (dirty data)

Init by InsertNeighborsById in the constructor and Resize.

@nedchu nedchu changed the title [WIP] feat: add compressed graph in normal graph datacell feat: add compressed graph in normal graph datacell Jun 23, 2025
@nedchu nedchu requested a review from jiaweizone June 23, 2025 11:22
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
@wxyucs wxyucs added version/0.15 kind/feature New feature or request labels Jun 23, 2025
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nedchu added 2 commits June 23, 2025 20:18
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
InnerIdType current = total_count_.load();
while (current < id + 1 && !total_count_.compare_exchange_weak(current, id + 1)) {
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IVF will be influenced by total_count_. Fix the segmentation fault

nedchu and others added 8 commits June 24, 2025 22:58
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Xiangyu Wang <wxy407827@antgroup.com>
nedchu added 4 commits June 25, 2025 14:27
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (76.47%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   90.54%   90.13%   -0.42%     
==========================================
  Files         222      218       -4     
  Lines       14972    14461     -511     
==========================================
- Hits        13556    13034     -522     
- Misses       1416     1427      +11     
Flag Coverage Δ
cpp 90.13% <76.47%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.73% <ø> (ø)
datacell 91.18% <100.00%> (-0.59%) ⬇️
index 88.39% <0.00%> (-0.09%) ⬇️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837329f...03e22fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

nedchu added 2 commits June 27, 2025 19:17
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Signed-off-by: Deming Chu <chudeming.cdm@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support graph compression in graph datacell

4 participants