You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds reuse_instance on embedded App: when BUILDING_GALLERY is True, passing reuse_instance=True skips the gallery instance-sharing path for that constructor (same effect as not using gallery sharing for that call), without setting BUILDING_GALLERY to False globally.
Examples
Opt out of gallery sharing for one App while the flag stays on:
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.32%. Comparing base (f3a3696) to head (1efdddf). ⚠️ Report is 1 commits behind head on main.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci/cdInvolves the GitHub workflow filesdocumentationImprovements or additions to documentationenhancementNew features or code improvementsmaintenancePackage and maintenance related
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1378
What changed
Adds
reuse_instanceon embeddedApp: whenBUILDING_GALLERYisTrue, passingreuse_instance=Trueskips the gallery instance-sharing path for that constructor (same effect as not using gallery sharing for that call), without settingBUILDING_GALLERYtoFalseglobally.Examples
Opt out of gallery sharing for one
Appwhile the flag stays on:Default (unchanged):
reuse_instance=False— gallery sharing still followsBUILDING_GALLERY.Tests & docs
tests/scripts/reuse_instance_test.py·tests/embedding/test_app.py(test_reuse_instance_bypasses_gallery_sharing)doc/source/user_guide/howto/globals.rst