Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

Rename 'target' to 'targets' in notification template API doc #659

Open
samcarpentier wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rename 'target' to 'targets' in notification template API doc #659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63e4a57
Rename 'target' to 'targets' in notification template API doc
Jan 24, 2019
4d29a59
Rename 'target' to 'targets' in notification_template resource
Jan 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/api_ref/resources/notification_template.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Fields Table
+---------------------------+----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------+----------+-------+-----------+---------+
|nickname |String |[irc]The irc nick. |False |False |True |False |
+---------------------------+----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------+----------+-------+-----------+---------+
|target |String |[irc]The distination channels or users. |False |False |True |False |
|targets |String |[irc]The distination channels or users. |False |False |True |False |
+---------------------------+----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------+----------+-------+-----------+---------+

.. <table goes here>
Expand Down
8 changes: 4 additions & 4 deletions tower_cli/resources/notification_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ class Resource(models.Resource):
help_text='[{0}]Server address.'.format('irc'))
nickname = models.Field(required=False, display=False,
help_text='[{0}]The irc nick.'.format('irc'))
target = models.Field(required=False, display=False,
help_text='[{0}]The distination channels or users.'
.format('irc'))
targets = models.Field(required=False, display=False,
help_text='[{0}]The distination channels or users.'
.format('irc'))

def _separate(self, kwargs):
"""Remove None-valued and configuration-related keyworded arguments
Expand Down Expand Up @@ -188,7 +188,7 @@ def _configuration(self, kwargs, config_item):
nc[field] = config_item[field]
else:
kwargs['notification_configuration'] = \
config_item['notification_configuration']
config_item['notification_configuration']

@resources.command
@click.option('--job-template', type=types.Related('job_template'),
Expand Down