Skip to content
This repository was archived by the owner on Sep 16, 2020. It is now read-only.

Conversation

@jomeier
Copy link

@jomeier jomeier commented Aug 5, 2018

Hi,

I'm working on an tower export/import script and try to use tower-cli for that.

I described in this bug report that an import of inventories with groups and hosts in it will fail, because the group arrays don't have a 'name' field:

#582

This PR fixes that. Import of inventories with

tower-cli send inventory.json

now works.

I would be glad if someone could check that and accept this PR.

Thanks and best regards,

Josef

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 63.705% when pulling d8f6f57 on jomeier:additional-name-field-in-groups into 9a22336 on ansible:master.

@jomeier jomeier changed the title Added 'name' field to inventory groups. Make import of 'inventory' groups possible Aug 5, 2018
@jomeier
Copy link
Author

jomeier commented Aug 6, 2018

I have no idea how to increase the code coverage. I only added one line of code with a variable assignment :-)

@AlanCoding
Copy link
Member

If you add a line of code, then you increase the denominator for the code coverage calculation. All it means here is that the linear block of code where you added the line doesn't have coverage. For this, it's not a concern.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants