Skip to content

Conversation

@chynasan
Copy link
Member

Pushing this now in case anyone has feedback - based on https://issues.redhat.com/browse/AAP-51535.

@chynasan chynasan marked this pull request as ready for review September 16, 2025 17:44
Copy link
Contributor

@GomathiselviS GomathiselviS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the logic gets more complicated, I suggest you move it into a dedicated script file. There is already some logic that should be moved into dedicated functionalities so that it can be used for both schema and spec files without having to write redundant code.

@chynasan
Copy link
Member Author

Spec file tests:
Spec file with changes to dev version (should pass): See logs
New 2.0.0 spec file with version match (should pass): See logs
New 2.0.0 spec file with version MISmatch (should fail): See logs
Changes to 1.0.0 spec file or other existing spec file (should fail): See logs

Schema file tests:
Schema file with changes to dev version (should pass): See logs
New 3.0.0 schema file with version match (should pass): See logs
New 2.0.0 schema file with version MISmatch in itself (should fail): See logs
New 2.0.0 schema file with version MISmatch in latest (should fail): See logs
Changes to 1.0.0 or other existing schema file (should fail): See logs

@sonarqubecloud
Copy link

@chynasan chynasan requested a review from a team September 17, 2025 19:45
@chynasan chynasan merged commit 1178ccb into ansible:main Sep 17, 2025
6 checks passed
@chynasan chynasan deleted the validate-schema branch September 17, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants