-
Notifications
You must be signed in to change notification settings - Fork 10
Validate schema #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate schema #41
Conversation
…ments were addressed.
GomathiselviS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alinabuzachis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the logic gets more complicated, I suggest you move it into a dedicated script file. There is already some logic that should be moved into dedicated functionalities so that it can be used for both schema and spec files without having to write redundant code.
…x bugs related to the latest version checks
|
Spec file tests: Schema file tests: |
|



Pushing this now in case anyone has feedback - based on https://issues.redhat.com/browse/AAP-51535.