Updating transitive dependency "constantly" #1448
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 234 234
Lines 10046 10046
=======================================
Hits 9156 9156
Misses 890 890
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
| # transitive dependency needed by Daphne to resolve conflicts in Konflux build | ||
| # adding here to be captured in the building of the | ||
| # `requirements-poetry-export.in` file | ||
| constantly = ">=23.10.4,<24" |
There was a problem hiding this comment.
you don't need to add this here constraint; simply update the locked/pinned version of constantly to the latest one
also, neither "konflux" nor "requirements-poetry-export.in" make sense to be mentioned here: the upgrade of constantly is needed likely because the pinned version does not support python 3.12+ (which is what needs to be mentioned as commit message instead)
There was a problem hiding this comment.
copied from slack... " @ptoscano I added the constantly dependency in eda-server because that is where the requirements-poetry-export.in originates. I tried to add it in the requirements-constraints.in file, but that caused conflicts. since all the other files are generated, it made sense to make the change at the origin, eda-server. Where else would you recommend this dependency be added?"
There was a problem hiding this comment.
it appears when exporting the requirements using poetry export because it is in the poetry lock file at that version; so updating the locked version to a newer version should fix this, as I mentioned
3 participants
Updating transitive dependency, "constantly" needed by Daphne to resolve conflicts in Konflux build. Adding here to be captured in the building of the
requirements-poetry-export.infile from theautomation-eda-controller-container