Skip to content

awxkit: Add packaging dependency#16383

Open
lalten wants to merge 1 commit intoansible:develfrom
lalten:packaging
Open

awxkit: Add packaging dependency#16383
lalten wants to merge 1 commit intoansible:develfrom
lalten:packaging

Conversation

@lalten
Copy link
Copy Markdown

@lalten lalten commented Apr 1, 2026

SUMMARY

Add packaging dependency - this dependency is used in a couple of places, but was never declared as dependency.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • CLI
STEPS TO REPRODUCE AND EXTRA INFO

In Bazel, I'm doing something like

load("@rules_python//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")

py_console_script_binary(
    name = "awx",
    env = {"CONTROLLER_HOST": "https://awx.internal.company.tld/"},
    pkg = "@pypi//awxkit",
    visibility = ["//visibility:public"],
)

Before:

  File "/home/user/.cache/bazel/_bazel_user/fa93f079bfa192f0c08be5359885d53a/execroot/_main/bazel-out/k8-fastbuild/bin/third_party/awxkit/awx.runfiles/_main/third_party/awxkit/awx_entry_point.py", line 11, in <module>
    from awxkit.cli import run
  File "/home/user/.cache/bazel/_bazel_user/fa93f079bfa192f0c08be5359885d53a/execroot/_main/bazel-out/k8-fastbuild/bin/third_party/awxkit/awx.runfiles/rules_python++pip+pypi_313_awxkit/site-packages/awxkit/__init__.py", line 3, in <module>
    from awxkit import awx  # NOQA
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/.cache/bazel/_bazel_user/fa93f079bfa192f0c08be5359885d53a/execroot/_main/bazel-out/k8-fastbuild/bin/third_party/awxkit/awx.runfiles/rules_python++pip+pypi_313_awxkit/site-packages/awxkit/awx/__init__.py", line 1, in <module>
    from packaging.version import Version
ModuleNotFoundError: No module named 'packaging'

After:

❯ bazel run //third_party/awxkit -- --version 2>/dev/null
0.1.dev34867+gb387b3084

Summary by CodeRabbit

  • Chores
    • Updated package dependencies to support enhanced functionality.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dee4e7c9-aa48-4435-a628-c644795639fa

📥 Commits

Reviewing files that changed from the base of the PR and between e80ce43 and b387b30.

📒 Files selected for processing (1)
  • awxkit/setup.py

📝 Walkthrough

Walkthrough

A packaging dependency was added to the install_requires list in the setup configuration file to include an additional package requirement for the awxkit project.

Changes

Cohort / File(s) Summary
Dependency Configuration
awxkit/setup.py
Added 'packaging' to the install_requires list to declare a new package dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly summarizes the main change: adding the 'packaging' dependency to awxkit's installation requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant