Address Lookup Plugins AttributeError#15770
Merged
thedoubl3j merged 3 commits intoansible:develfrom Jan 29, 2025
Merged
Conversation
Member
|
Rebasing should clear up the checks |
thedoubl3j
force-pushed
the
managedcredtype_attribute_error
branch
2 times, most recently
from
c6a7a3e to
4b61616
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
Jaapis
approved these changes
Jan 29, 2025
Contributor
Jaapis
left a comment
Jaapis
left a comment
There was a problem hiding this comment.
This commit looks great! Testing locally it fixes almost 60 of our broken tests.
* managedcredential may now contain 2 different classes * managedcredentialType and one that represents a lookup plugin
* added a conditional statement to filter our external types
thedoubl3j
force-pushed
the
managedcredtype_attribute_error
branch
from
4b61616 to
4adeb44
Compare
|
chrismeyersfsu
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
We lost the
backendfunction when saving lookup plugins to the registry with #15685.ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION