Adopt custom_injectors change from awx-plugins#15638
Merged
chrismeyersfsu merged 5 commits intoansible:develfrom Dec 10, 2024
Merged
Adopt custom_injectors change from awx-plugins#15638chrismeyersfsu merged 5 commits intoansible:develfrom
chrismeyersfsu merged 5 commits intoansible:develfrom
Conversation
github-actions
bot
added
component:api
dependencies
chrismeyersfsu
force-pushed
the
AAP-25749-move-inject-credential
branch
2 times, most recently
from
387a115 to
813348b
Compare
chrismeyersfsu
changed the title
chrismeyersfsu
force-pushed
the
AAP-25749-move-inject-credential
branch
2 times, most recently
from
9d8e59e to
34229f2
Compare
Member
|
I assume checks are failing due to the dependency. Otherwise looks good. |
chrismeyersfsu
force-pushed
the
AAP-25749-move-inject-credential
branch
2 times, most recently
from
ad1fcbc to
8d57cd3
Compare
github-actions
bot
removed
the
dependencies
* Unit tests do not create CredentialType records for Credential plugins. Instead, they explicitly instantiate CredentialType(s) for Credential plugins. They rely on CredentialType.defaults[key] to do so. This change makes sure custom_injectors get bolted onto the created CredentialType.
chrismeyersfsu
force-pushed
the
AAP-25749-move-inject-credential
branch
from
f857235 to
8ccb32b
Compare
|
AlanCoding
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Related PR ansible/awx-plugins#57
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION