Conversation
|
@thedoubl3j It should be possible to rebase now. Check what jobs are green on |
thedoubl3j
force-pushed
the
add_assumerole
branch
from
67de58a to
af9404e
Compare
|
FYI, PEP 257-compliant docstrings are always made of triple double-quotes. |
thedoubl3j
force-pushed
the
add_assumerole
branch
from
cfeb4c8 to
5266f82
Compare
|
@thedoubl3j plz also add the entry point to the smoke test params @ https://github.com/ansible/awx-plugins/blob/82c8c95/tests/importable_test.py#L27-L73 |
|
Rebase this. From now on, all the GHA checks are expected to show up green. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
thedoubl3j
force-pushed
the
add_assumerole
branch
from
3d17a14 to
cbeea1c
Compare
|
@thedoubl3j this will end up in https://github.com/ansible/awx_plugins.credential.aws_assumerole eventually. That repo doesn't yet have Git history, but it will. Still, it's useful to do an interactive rebase with the commit cleanup here and fix the conflicts. This will help re-graft this branch into the new repo. |
|
Hi folks, I'm just checking in on the status of this PR? The repo reference in the last comment must be private, because it 404s for me, but I'm interested in following the progress of getting this change into AWX. Thanks! |
|
@derekwaters we didn't end up splitting the plugins repo further at the time. This is on hold for now. |
|
Any update on this, we are still waiting this to be implemented |
4 participants
Adding in the AWS assume role cred plugin authored by @derekwaters found in this AWX PR.