Open
Conversation
* we as a team need to discuss what we want this to be, currently lowering to help unblock some work but a larger discussion is needed
AlanCoding
approved these changes
May 1, 2025
djyasin
approved these changes
May 2, 2025
Member
|
I thought the linter failure couldn't possibly be serious, but it appears it is: Clearly, the suggestion would just undo this change. Perhaps it means there is a duplicate value somewhere else (not stated in the error message) that is at 100% and needs to be 90% to have parity. |
Member
|
@AlanCoding that's a check for configs having a certain required setting. |
Member
|
In general, I don't think this is a good idea to accept this patch. It has already helped uncover bugs in implementation+tests of #106. This would be increasing the likelihood of sneaking more bugs in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will become part of a larger effort to understand the CI of awx-plugins and adjust as needed to bring it in line with ATF.