Skip to content

Fix logic to read ACK/NACK in send function#14

Merged
anotherjulien merged 1 commit intoanotherjulien:masterfrom
michnovka:fix-send-logic
Jan 18, 2025
Merged

Fix logic to read ACK/NACK in send function#14
anotherjulien merged 1 commit intoanotherjulien:masterfrom
michnovka:fix-send-logic

Conversation

@michnovka
Copy link
Copy Markdown
Contributor

Fixes #8

@anotherjulien
Copy link
Copy Markdown
Owner

Thank you for finding, and fixing the issue!
As discussed here michnovka/HomeAssistant-MyHOME#8, I might rework a bit the loop condition, and maybe the retry count implementation (i.e. passing the maximum number of attempts in parameter instead of the counter itself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OWNd sometimes receives temperature WHO=4 as response to WHO=1

2 participants