Iter15 #16
Merged
Iter15 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat(repository): added method for getting all user urls (by user_id); - feat(middleware): added security cookie for identificate user; - chore(repository): update migrations; - feat(handler): added handler for getting user urls;
- feat(repository): update model, added batch method for update list; - feat(core): added fanIn worker; - feat(handler): added delete urls handler; - chore(migrations): update migrations;
Perederey
reviewed
Jan 29, 2026
Perederey
left a comment
Perederey
left a comment
There was a problem hiding this comment.
Привет! В целом хорошо справился с заданием!
Из того, на что стоит обратить внимание:
- При переполнении канала ты просто пропускаешь URL (default case), а пользователь получит 202, но URL не удалится. Это проблема
- Два канала захардкожены в коде, лучше сделать конфигурируемым количество
- Service слой не должен лезть в контекст за user_id, это дело handler слоя
- Много дублирования кода (проверка user_id, получение из контекста), выноси в хелперы
А так молодец! Продолжай в том же духе!
| } | ||
|
|
||
| // fanIn объединяет несколько каналов в один | ||
| func (w *DeleteWorker) fanIn(channels ...<-chan DeleteRequest) <-chan DeleteRequest { |
There was a problem hiding this comment.
Когда один из входных каналов закрывается, горутина завершается, но выходной канал out никогда не закрывается. Это может привести к тому, что processDeletes будет висеть в ожидании. Нужен механизм отслеживания завершения всех входных каналов через sync.WaitGroup
| c.Next() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Ключ должен приходить из конфига или environment переменн
| c.Set(UserIDContextKey, userID) | ||
| c.Next() | ||
| } | ||
| } |
There was a problem hiding this comment.
В Go принято всегда проверять ошибки, даже если они маловероятны
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлено асинхронное удаление записей из БД