Iter13 #14
Merged
Iter13 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- feat(repository): added DB connection; - feat(handler): added `ping` path to check DB connection;
- feat(repository): added methods Select and Insert; - refactor(all): refactored project: splited repository layer, splited service layer; - update(tests): updated handler tests;
- feat(handler): added urls batch handler; - feat(repository): added transaction method for inserting urls batch; - chore(tests): update tests;
- feat(handler): added error catching for unique url; - feat(repository): added method for getting unique entry; - chore(tests): update tests;
s-shpak
suggested changes
Jan 20, 2026
| var dbService *serviceDB.DBService | ||
|
|
||
| // Try to connect to database if DSN is provided | ||
| if cfg.DSN != "" { |
There was a problem hiding this comment.
См. мой ответ. Если ты завершишься с ошибкой при заданном cfg.DSN, то это не сломает тесты предыдущих спринтов
| if errors.As(err, &conflictErr) { | ||
| // URL уже существует, возвращаем 409 | ||
| c.Writer.WriteHeader(http.StatusConflict) | ||
| _ = json.NewEncoder(c.Writer).Encode(APIResponse{Result: shortURL}) |
There was a problem hiding this comment.
Ошибку здесь можно залогировать для информации
internal/service/service.go
Outdated
| var dbErr error | ||
| if s.DB != nil { | ||
| // Safely call DB.Insert with panic recovery | ||
| func() { |
There was a problem hiding this comment.
Паники лучше отлавливать при помощи middleware. Тогда хендлеры паник не придется регистрировать на каждом уровне
internal/service/service.go
Outdated
| } | ||
| } | ||
|
|
||
| if s.Disk != nil { |
There was a problem hiding this comment.
Это очень сложный код. Почему бы не определить единый интерфейс для работы с БД и с файловым хранилищем, и не пользоваться им? Тогда для слоя сервисов будет безразлично, каким именно хранилищем он пользутеся. Это сильно упростит код этого слоя
- refactor(repository): define single interface for all storages; - feat(middleware): added panic recovery middleware;
s-shpak
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена работа с БД. Устранены замечания