Conversation
anomic30
left a comment
anomic30
left a comment
There was a problem hiding this comment.
Please don't remove the .env.example file. Add those back again and raise a PR.
|
Hey, the color of the button text and the font style is not according to the UI. Please fix those. Current: Required: |
anomic30
left a comment
anomic30
left a comment
There was a problem hiding this comment.
Why did you expose the API keys? It should be kept empty.
Kindly go through our main branch to check the content of the .env.example
Yeahh I did it by mistake . I'll remove them |
|
Hey, you forgot to remove the API keys from the server/.env.example also. |
|
I'm just First timer in hacktoberfest. Sorry for the inconvenience . I've removed the keys from both the files . Also When the popup Appears. I'm not able to make the background a bit transparent . Do tell if i've to make anymore improvements in my PR. |
…t/logoutModal changes pulled
|
I've changed the background also for when the popup appears . You can check it for potential mistakes 😅 |
Sneakad
left a comment
Sneakad
left a comment
There was a problem hiding this comment.
@Aniket1026 can you please bring the modal in the middle of the display?
|
@Sneakad Done . Does it looks fine now ? |
Aniket1026
requested review from
Sneakad and
anomic30
and removed request for
Sneakad and
anomic30
Aniket1026
requested review from
Sneakad and
anomic30
and removed request for
Sneakad and
anomic30
anomic30
left a comment
anomic30
left a comment
There was a problem hiding this comment.
Please indent the code as it was before.
| <Route path="/app" element={<Main />}> | ||
| <Route path="/app/home" element={<Home />} /> | ||
| <Route path="/app/myFiles" element={<MyFiles />} /> | ||
| <Route |
| <Main setLogoutModal={setLogoutModal} logoutModal={logoutModal} /> | ||
| } | ||
| > | ||
| <Route |
| import Axios from 'axios'; | ||
| import Tippy from '@tippyjs/react' | ||
| import 'tippy.js/dist/tippy.css' | ||
| import React, { useContext, useState } from "react"; |
There was a problem hiding this comment.
Remove double quotation for all the imports
…t/logoutModal pulled changes
3 participants
Description
Successfully added the logout Modal which popups when Logout button is clicked asking the user if he wants to logout or not ?
Fixes # (issue)
Type of change
Checklist: