fix(runtime): prevent goroutine leak and panic in node worker logs #6294
+21
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes intermittent panics and goroutine leaks in the Node.js runtime worker's log streaming functionality that occur when workers are stopped or killed during development.
Problem
The stack trace you provided shows panics occurring in
(*Worker).Logswhen workers are terminated:The root cause was the use of
io.Copy()for streaming stdout/stderr. When a worker process is killed:io.Copydoesn't gracefully handle write errors to closed pipesSolution
Replaced
io.Copywith a manual buffered read/write loop that:writer.Close()afterwg.Wait()(was incorrectly usingdeferbefore the wait)Changes
pkg/runtime/node/node.go:io.Copygoroutines with a reusablecopyStreamfunctionTesting
pkg/runtime/python/python.gowhich doesn't have these issuespkg/runtime/runtime.goThis should eliminate the intermittent panics you're experiencing during
sst devwhen functions are rebuilt or workers are restarted.