feat(aws/vpc): expose security groups for NAT and bastion instances #6283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add natSecurityGroup and bastionSecurityGroup to Vpc component properties - Return security group references from createNatInstances() and createBastion() - Update component state to track and persist security groups - Add documentation for new security group outputs This allows users to reference and modify security groups for NAT and bastion instances when needed for custom networking configurations. Addresses anomalyco#6282.
Author
|
I omitted reference handling - fixing now. |
Add logic to import existing NAT instance and bastion security groups when using an existing VPC. The security groups are tagged with `sst:is-nat-sg` and `sst:is-bastion-sg` respectively, allowing them to be discovered and imported into the Pulumi state. Addresses anomalyco#6282.
Wrap the error throw inside vpcId.apply() to properly resolve the Pulumi Output before displaying the VPC ID in the error message. This prevents showing an unresolved Output object in the error text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to reference and modify security groups for NAT and bastion instances when needed for custom networking configurations.
Addresses #6282.