feat: add configuration for open ai store option on provider level #7315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For organizations with ZDR enabled, currently we need to manually set the "store" option for every open ai model in configuration. This change adds support to specify it once on the provider level instead. Ref: anomalyco#2966
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Author
|
A seperate note, but this existing snippet seems to possibly be dead code, or uninentional: The "provider ID" would not possibly include codex, was this supposed to check against the model with model.api.id? Or is there actually a provider with the keyword "codex" in it? But not sure why this was required in the first place as well 😅 |
Contributor
|
cc @rekram1-node can I bug you for a review on this one? need it to use OpenAI models & their zero data retention config in OC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For organizations with ZDR enabled, currently we need to manually set the "store" option for every open ai model in configuration. This change adds support to specify it once on the provider level instead. Ref: #2966