perf: show window immediately during desktop startup #6734
+127
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the window was only created after the sidecar server was ready (up to 7 seconds). Now the window is created immediately and shows a loading screen while the server starts in the background. Changes: - Create window synchronously in setup() instead of async spawn - Add serverReady flag and opencode:server-ready event - Add DesktopServerGate component to show loading screen - Dispatch event when server is ready to hide loading screen
usvimal
force-pushed
the
perf/desktop-startup-optimization
branch
from
080c864 to
b5e95e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the desktop app window was only created after the sidecar server was ready (up to 7 seconds). Users saw nothing during this time. Now the window appears immediately with a loading screen.
Changes
Rust (lib.rs)
setup()instead of inside async spawnserverReady = falseto initialization scriptopencode:server-readyevent when server is readyTypeScript (app.tsx)
DesktopServerGatecomponent that shows loading screenopencode:server-readyevent to hide loadingBefore/After
Testing