feat(tui): also display the permission indicator in the sidebar's footer (resolves #5546) #5547
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariane-emory
changed the title
Contributor
Author
|
@rekram1-node Any thoughts on this one? Seems like a pretty simple and helpful change to me. I've been running it locally for several days and its been working great for me. |
ariane-emory
force-pushed
the
feat/permission-indicator-in-sidebar
branch
from
253e2f4 to
9f1e726
Compare
…ane-emory/opencode into feat/permission-indicator-in-sidebar
…ane-emory/opencode into feat/permission-indicator-in-sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the permission indicators added by @terakael's wonderful recently-merged PR, covering the case where the sidebar is enabled: currently, when the sidebar is enabled, the permission indicator does not appear. With this PR, the permission indicator will appear in the sidebar's footer when the sidebar is enabled, making its behaviour more consistent across sidebar visibility states and eliminating a potential surprise for users not anticipating the current inconsistent behaviour.
Resolves #5546.